rgonsal/comunidadhll
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix stats player profile weekly monthly 500

Browse Source
This commit is contained in:
devRaGonSa
2026-06-11 14:44:06 +02:00
parent beecc90fa7
commit 2b5f9c56e3
3 changed files with 188 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
backend/app/rcon_historical_player_stats.py
View File

@@ -544,15 +544,23 @@ def _get_player_period_stats_read_model(
selected_row = rows_by_period[timeframe]
weekly_row = rows_by_period["weekly"]
monthly_row = rows_by_period["monthly"]
with _connect_read_scope(resolved_path, db_path=db_path) as connection:
active_time = _fetch_player_active_time_summary(
connection=connection,
player_id=player_id,
server_id=resolved_server_id,
window={
"start": _to_datetime_or_none(selected_row.get("period_start")),
"end": _to_datetime_or_none(selected_row.get("period_end")),
},
active_time = _build_profile_missing_active_time_payload(
total_matches_considered=int(selected_row.get("matches_considered") or 0),
)
try:
with _connect_read_scope(resolved_path, db_path=db_path) as connection:
active_time = _fetch_player_active_time_summary(
connection=connection,
player_id=player_id,
server_id=resolved_server_id,
window={
"start": _to_datetime_or_none(selected_row.get("period_start")),
"end": _to_datetime_or_none(selected_row.get("period_end")),
},
total_matches_considered=int(selected_row.get("matches_considered") or 0),
)
except Exception:
active_time = _build_profile_missing_active_time_payload(
total_matches_considered=int(selected_row.get("matches_considered") or 0),
)
return (
@@ -1011,6 +1019,22 @@ def _build_profile_active_time_payload(
},
}
return _build_profile_missing_active_time_payload(
total_matches_considered=total_matches_considered,
min_active_seconds=min_active_seconds,
)
def _build_profile_missing_active_time_payload(
*,
total_matches_considered: int,
min_active_seconds: int | None = None,
) -> dict[str, object]:
resolved_min_active_seconds = (
min_active_seconds
if isinstance(min_active_seconds, int) and min_active_seconds > 0
else get_kpm_min_active_seconds()
)
return {
"player_active_seconds": None,
"player_active_minutes": None,
@@ -1023,7 +1047,7 @@ def _build_profile_active_time_payload(
"observed_matches": 0,
"total_matches_considered": total_matches_considered,
"eligible_kills": 0,
"minimum_active_seconds": min_active_seconds,
"minimum_active_seconds": resolved_min_active_seconds,
"sources": [],
},
}
@@ -1652,17 +1676,7 @@ def _build_missing_player_period_stats_result(
"player_active_seconds": None,
"player_active_minutes": None,
"kpm": None,
"kpm_status": "missing_active_time",
"active_time_source": "unavailable",
"active_time_coverage": {
"eligible_matches": 0,
"real_source_matches": 0,
"observed_matches": 0,
"total_matches_considered": 0,
"eligible_kills": 0,
"minimum_active_seconds": get_kpm_min_active_seconds(),
"sources": [],
},
**_build_profile_missing_active_time_payload(total_matches_considered=0),
**build_external_player_profile_fields(player_id=player_id),
"weekly_ranking": None,
"monthly_ranking": None,

75
backend/tests/test_stats_player_profile_payload.py
View File

@@ -11,6 +11,81 @@ from app.rcon_historical_player_stats import (
class StatsPlayerProfilePayloadTests(unittest.TestCase):
def test_player_stats_read_model_keeps_payload_valid_when_active_time_lookup_fails(self) -> None:
selected_row = {
"period_type": "weekly",
"window_kind": "current-week",
"period_start": "2026-06-01T00:00:00Z",
"period_end": "2026-06-08T00:00:00Z",
"server_id": "all-servers",
"player_id": "76561198000000000",
"player_name": "Steam Player",
"matches_considered": 4,
"kills": 20,
"deaths": 10,
"teamkills": 0,
"ranking_position": 4,
"updated_at": "2026-06-11T12:00:00Z",
"first_seen_at": "2026-06-01T01:00:00Z",
"last_seen_at": "2026-06-08T01:00:00Z",
}
with (
patch(
"app.rcon_historical_player_stats._get_player_period_stats_read_model",
return_value=(
{
"player_id": "76561198000000000",
"player_name": "Steam Player",
"server_id": "all-servers",
"timeframe": "weekly",
"window_start": None,
"window_end": None,
"window_kind": "current-week",
"matches_considered": 4,
"kills": 20,
"deaths": 10,
"teamkills": 0,
"player_active_seconds": None,
"player_active_minutes": None,
"kpm": None,
"kpm_status": "missing_active_time",
"active_time_source": "unavailable",
"active_time_coverage": {
"eligible_matches": 0,
"real_source_matches": 0,
"observed_matches": 0,
"total_matches_considered": 4,
"eligible_kills": 0,
"minimum_active_seconds": 60,
"sources": [],
},
"platform": "steam",
"steam_id_64": "76561198000000000",
"external_profile_links": {
"steam": "https://steamcommunity.com/profiles/76561198000000000",
"hellor": "https://hellor.pro/player/76561198000000000",
"hll_records": "https://hllrecords.com/profiles/76561198000000000",
"helo": "https://helo-system.de/statistics/players/76561198000000000?series=2024",
},
"weekly_ranking": {"metric": "kills", "ranking_position": 4},
"monthly_ranking": {"metric": "kills", "ranking_position": 7},
"source": {"primary_source": "rcon", "read_model": "player-period-stats"},
},
None,
),
),
):
payload = build_stats_player_profile_payload(
player_id="76561198000000000",
timeframe="weekly",
)
data = payload["data"]
self.assertEqual(data["matches_considered"], 4)
self.assertIsNone(data["kpm"])
self.assertEqual(data["kpm_status"], "missing_active_time")
self.assertIn("steam", data["external_profile_links"])
def test_player_stats_returns_lightweight_missing_payload_when_period_read_model_is_empty(self) -> None:
with patch(
"app.rcon_historical_player_stats._get_player_period_stats_read_model",