From 9e52be98de80410684c0e37b085a04bf98cf3838 Mon Sep 17 00:00:00 2001 From: devRaGonSa Date: Thu, 11 Jun 2026 10:58:00 +0200 Subject: [PATCH] Polish public home stats ranking copy and player id visibility --- ...s-ranking-copy-and-player-id-visibility.md | 83 +++++++++++++++++++ frontend/assets/css/styles.css | 20 ++--- frontend/assets/js/historico-recent-live.js | 6 +- frontend/assets/js/ranking.js | 17 ++-- frontend/assets/js/stats.js | 35 ++++++-- frontend/historico.html | 14 ++-- frontend/index.html | 7 +- frontend/stats.html | 13 +-- 8 files changed, 144 insertions(+), 51 deletions(-) create mode 100644 ai/tasks/done/TASK-246-polish-public-home-stats-ranking-copy-and-player-id-visibility.md diff --git a/ai/tasks/done/TASK-246-polish-public-home-stats-ranking-copy-and-player-id-visibility.md b/ai/tasks/done/TASK-246-polish-public-home-stats-ranking-copy-and-player-id-visibility.md new file mode 100644 index 0000000..3f6a445 --- /dev/null +++ b/ai/tasks/done/TASK-246-polish-public-home-stats-ranking-copy-and-player-id-visibility.md @@ -0,0 +1,83 @@ +--- +id: TASK-246 +title: Polish public home stats ranking copy and player id visibility +status: done +type: frontend +team: Frontend Senior +supporting_teams: + - Experto en interfaz +roadmap_item: foundation +priority: medium +--- + +# TASK-246 - Polish public home stats ranking copy and player id visibility + +## Goal + +Refine public frontend copy in home, stats and ranking, and stop showing player IDs in the public stats and ranking tables. + +## Context + +The scheduler and backend public reads were already validated. This task only adjusts visible frontend UI and copy: + +- make the home countdown capsule more noticeable without widening it +- remove explanatory helper copy that adds noise in public panels +- remove the initial empty search state box in stats +- keep `all-servers` as an internal slug while presenting `Todos los servidores` +- stop rendering player IDs in public table rows + +## Steps + +1. Reviewed the real HTML and JS used by home, stats, ranking and the visible recent matches section. +2. Removed noisy helper copy from the relevant public sections. +3. Hid the initial stats search state box while preserving validation and error states. +4. Normalized annual stats server labels for visible output. +5. Removed player ID rendering from the public annual stats table and the ranking table. +6. Polished the countdown capsule styling with a stronger but still compact warm accent. + +## Files to Read First + +- `AGENTS.md` +- `ai/architecture-index.md` +- `ai/repo-context.md` +- `frontend/index.html` +- `frontend/stats.html` +- `frontend/ranking.html` +- `frontend/assets/js/stats.js` +- `frontend/assets/js/ranking.js` +- `frontend/assets/css/styles.css` + +## Expected Files to Modify + +- `frontend/index.html` +- `frontend/stats.html` +- `frontend/historico.html` +- `frontend/assets/js/historico-recent-live.js` +- `frontend/assets/js/stats.js` +- `frontend/assets/js/ranking.js` +- `frontend/assets/css/styles.css` + +## Constraints + +- No backend changes. +- No docker-compose or scheduler changes. +- No asset or image changes. +- Keep search by name or ID working internally. +- Keep `all` and `all-servers` as internal values only. + +## Validation + +- `node --check frontend/assets/js/stats.js` +- `node --check frontend/assets/js/ranking.js` +- Search frontend for the removed visible copy strings. +- Search frontend for `Objetivo:` regression. +- Check that stats and ranking table rows no longer render player IDs. + +## Outcome + +- Home countdown label is visually stronger without stretching full width. +- The extra helper copy under public servers is gone. +- The redundant recent matches note was removed from the visible panel where it was actually rendered. +- Stats no longer shows the initial search status box before any search. +- Annual stats visible server output now uses `Todos los servidores`. +- Stats annual rows and ranking rows no longer render player IDs in the public tables. diff --git a/frontend/assets/css/styles.css b/frontend/assets/css/styles.css index 35af24d..236c734 100644 --- a/frontend/assets/css/styles.css +++ b/frontend/assets/css/styles.css @@ -640,6 +640,14 @@ h2 { .release-countdown__copy .eyebrow--section { margin-bottom: 0; + border-color: rgba(210, 182, 118, 0.42); + background: + linear-gradient(180deg, rgba(82, 68, 33, 0.28), rgba(41, 49, 24, 0.62)); + color: #e0c487; + font-weight: 800; + box-shadow: + inset 0 1px 0 rgba(255, 255, 255, 0.03), + 0 10px 22px rgba(0, 0, 0, 0.18); } .release-countdown__units { @@ -1298,11 +1306,6 @@ h2 { line-height: 1.35; } -.stats-annual-player__id { - color: var(--muted); - font-size: 0.8rem; -} - .stats-annual-metric { color: var(--accent-warm); font-weight: 700; @@ -1613,12 +1616,7 @@ h2 { .ranking-player { display: grid; - gap: 4px; -} - -.ranking-player span { - color: var(--muted); - font-size: 0.82rem; + gap: 0; } .ranking-empty { diff --git a/frontend/assets/js/historico-recent-live.js b/frontend/assets/js/historico-recent-live.js index 6bab61c..0706ff8 100644 --- a/frontend/assets/js/historico-recent-live.js +++ b/frontend/assets/js/historico-recent-live.js @@ -83,7 +83,7 @@ } stateNode.hidden = true; - if (noteNode) noteNode.textContent = "Lista dinámica de partidas registradas."; + if (noteNode) noteNode.textContent = ""; metaNode.textContent = buildDynamicRecentMeta(items); renderDynamicRecentMatchesPage(); } catch (error) { @@ -92,8 +92,8 @@ } recentMatchesState.items = []; recentMatchesState.page = 1; - setDynamicState(stateNode, "No se pudieron cargar las partidas recientes dinámicas.", true); - metaNode.textContent = "Error al leer las partidas recientes dinámicas."; + setDynamicState(stateNode, "No se pudieron cargar las partidas recientes dinámicas.", true); + metaNode.textContent = "Error al leer las partidas recientes dinámicas."; renderDynamicPagination(); } } diff --git a/frontend/assets/js/ranking.js b/frontend/assets/js/ranking.js index 4df3ba3..22bb677 100644 --- a/frontend/assets/js/ranking.js +++ b/frontend/assets/js/ranking.js @@ -388,15 +388,14 @@ ); const hideKppColumn = metric === "kills_per_match"; - return ` - - #${safeInt(item.ranking_position, 0)} - -
- ${escapeHtml(String(item.player_name || "Jugador sin nombre"))} - ${escapeHtml(String(item.player_id || "Sin ID"))} -
- + return ` + + #${safeInt(item.ranking_position, 0)} + +
+ ${escapeHtml(String(item.player_name || "Jugador sin nombre"))} +
+ ${formatMetricValue(item.metric_value, metric)} ${safeInt(item.kills, 0)} ${safeInt(item.deaths, 0)} diff --git a/frontend/assets/js/stats.js b/frontend/assets/js/stats.js index 6c2cea2..f6ba870 100644 --- a/frontend/assets/js/stats.js +++ b/frontend/assets/js/stats.js @@ -111,7 +111,14 @@ if (!searchStateNode) { return; } - searchStateNode.textContent = message; + const normalizedMessage = String(message || "").trim(); + searchStateNode.hidden = !normalizedMessage; + if (!normalizedMessage) { + searchStateNode.textContent = ""; + searchStateNode.className = "stats-state stats-state--neutral"; + return; + } + searchStateNode.textContent = normalizedMessage; searchStateNode.className = `stats-state stats-state--${state}`; } @@ -296,6 +303,7 @@ const items = normalizeArray(data.items); const limit = safeInt(data.limit, 0); const serverId = String(data.server_id || annualServerId); + const serverLabel = labelForStatsServer(serverId); const sourceMatches = safeInt(data.source_matches_count, 0); const generatedAt = formatDateTime(data.generated_at); const year = safeInt(data.year, annualDefaultYear); @@ -313,7 +321,7 @@ setAnnualState( "neutral", - `${messages.annualReadyPrefix} ${serverId}, a\u00f1o ${year}.`, + `${messages.annualReadyPrefix} ${serverLabel}, a\u00f1o ${year}.`, ); annualContentNode.innerHTML = ` @@ -322,7 +330,7 @@

Servidor

- ${escapeHtml(serverId)} + ${escapeHtml(serverLabel)}

A\u00f1o

@@ -350,7 +358,6 @@ const rowsMarkup = items .map((item) => { const rank = safeInt(item.ranking_position, 0); - const playerId = escapeHtml(String(item.player_id || "")); const playerName = escapeHtml(String(item.player_name || "Jugador sin nombre")); const kills = safeInt(firstFiniteValue(item.kills, item.metric_value), 0); const matches = safeInt(item.matches_considered, 0); @@ -365,7 +372,6 @@
${playerName} - ID ${playerId}
${kills} @@ -948,10 +954,7 @@ } if (!query) { - setSearchState( - "neutral", - "Estado inicial: introduce al menos 4 caracteres para buscar un jugador.", - ); + setSearchState("neutral", ""); return; } @@ -968,5 +971,19 @@ .replaceAll('"', """) .replaceAll("'", "'"); } + + function labelForStatsServer(serverId) { + const normalized = String(serverId || "").trim().toLowerCase(); + if (normalized === "comunidad-hispana-01") { + return "Comunidad Hispana #01"; + } + if (normalized === "comunidad-hispana-02") { + return "Comunidad Hispana #02"; + } + if (normalized === "all" || normalized === "all-servers") { + return "Todos los servidores"; + } + return String(serverId || "Todos los servidores"); + } }); diff --git a/frontend/historico.html b/frontend/historico.html index 38494ed..f991b46 100644 --- a/frontend/historico.html +++ b/frontend/historico.html @@ -210,14 +210,12 @@
-
-
-

Partidas recientes

-

Últimas partidas registradas

-

- Lista de partidas ya registradas. -

-

+

+
+

Partidas recientes

+

Últimas partidas registradas

+

+

Cargando datos de partidas...

diff --git a/frontend/index.html b/frontend/index.html index 4e5b5af..f7e030d 100644 --- a/frontend/index.html +++ b/frontend/index.html @@ -93,9 +93,9 @@ aria-labelledby="release-countdown-title" >
-

+

Fecha de lanzamiento de Hell Let Loose Vietnam (13 de agosto) -

+

@@ -130,9 +130,6 @@ Actualizado no disponible

-

- El panel muestra el último estado disponible consultado de los servidores. -

Abrir zona histórico diff --git a/frontend/stats.html b/frontend/stats.html index e1fe817..2c034be 100644 --- a/frontend/stats.html +++ b/frontend/stats.html @@ -90,9 +90,13 @@
-

- Estado inicial: usa el buscador para encontrar jugadores. -

+
@@ -131,9 +135,6 @@

Ranking anual

Top 20 temporada 2026

-

- El ranking anual usa un corte ya preparado de la temporada para cargar el Top 20 sin recalcular toda la campaña en cada consulta. -

Temporada 2026