6.1 KiB
id, title, status, type, team, supporting_teams, roadmap_item, priority
| id | title | status | type | team | supporting_teams | roadmap_item | priority | |
|---|---|---|---|---|---|---|---|---|
| TASK-212 | Add killfeed weapon icon background | done | frontend | Frontend Senior |
|
foundation | medium |
TASK-212 - Add killfeed weapon icon background
Goal
Anadir una placa visual clara detras de los iconos de arma negros en la feed de bajas de partida-actual, sin modificar ningun SVG, asset fisico ni mapping de armas, para mejorar legibilidad dentro de la estetica militar sobria del proyecto.
Context
En frontend/assets/js/partida-actual.js, la feed de bajas renderiza iconos mediante renderKillFeedWeaponIcon(). Actualmente esa funcion devuelve directamente un <img class="current-match-killfeed__weapon-icon" ...>.
Despues de TASK-209, resolveKillFeedWeapon() prioriza globalThis.HLL_VIETNAM_CURRENT_MATCH_WEAPON_ICONS, definido en frontend/assets/js/current-match-weapon-icons.js, que apunta a iconos negros desde ./assets/img/weapons/black/. Como esos SVG tienen fondo transparente, en la feed se ve la silueta negra sin una base clara que la separe del fondo del panel.
La implementacion debe envolver el icono en un contenedor visual estable, mantener el fallback ? dentro de la misma placa o con estilo compatible, conservar el texto del arma visible y no alterar la fila de forma exagerada ni romper responsive.
Preserve the current product identity: Spanish-speaking HLL Vietnam community, military/Vietnam/tactical/sober visual direction and controlled repository evolution.
Steps
- Revisar los archivos listados en
Files to Read First, confirmando como se resuelve el icono, donde se renderiza el arma y donde viven los estilos reales del kill feed. - Modificar
renderKillFeedWeaponIcon()para envolver el icono en un contenedor especifico, por ejemplocurrent-match-killfeed__weapon-icon-frame. - Mantener el fallback
?dentro de la misma placa o con un estilo visual equivalente, sin cambiar el mapping de armas. - Anadir o ajustar CSS para dar al contenedor:
- fondo blanco o crema militar claro
- borde sutil
border-radiuspadding- tamano estable
display: gridyplace-items: center
- Mantener el
<img>conobject-fit: containy sin deformacion. - Validar sintaxis JS, revisar visualmente
partida-actualen local y documentar exclusiones.
Files to Read First
AGENTS.mdai/repo-context.mdai/architecture-index.mdfrontend/partida-actual.htmlfrontend/assets/js/partida-actual.jsfrontend/assets/js/current-match-weapon-icons.jsfrontend/assets/css/historico.css
Expected Files to Modify
ai/tasks/in-progress/TASK-212-add-killfeed-weapon-icon-background.mdfrontend/assets/js/partida-actual.jsfrontend/assets/css/historico.css
Optional only if strictly necessary:
frontend/partida-actual.htmlfrontend/assets/css/styles.css
Constraints
- Keep the change minimal.
- Preserve HLL Vietnam project identity.
- Do not introduce unnecessary frameworks or dependencies.
- Do not overwrite repository-specific context with generic platform template text.
- No ejecutar
ai-platform run. - No tocar
backend/ni endpoints. - No tocar
frontend/assets/img/weapons/. - No tocar SVGs.
- No modificar imagenes fisicas.
- No cambiar el mapping de armas.
- No reactivar Elo/MMR.
- No reintroducir Comunidad Hispana #03.
- Mantener compatibilidad con apertura directa en navegador y responsive.
Validation
Before completing the task ensure:
renderKillFeedWeaponIcon()envuelve el icono en un contenedor visual claro y estable- los iconos negros se ven sobre una caja clara/blanca integrada con la estetica militar de la feed
- el fallback
?usa la misma placa o un estilo compatible - el
<img>mantieneobject-fit: containy no se deforma - la fila del kill feed no crece de forma exagerada
- el texto del arma sigue visible
- se ejecuta:
node --check frontend/assets/js/partida-actual.js
node --check frontend/assets/js/current-match-weapon-icons.js
- se realiza inspeccion visual local de
partida-actual - se confirma que no se tocaron:
backend/frontend/assets/img/weapons/- SVGs
ai/system-metrics.md
git diff --name-onlymatches the expected scope- no unrelated files were modified
Outcome
Documentar:
- que cambio se hizo en
renderKillFeedWeaponIcon() - que clases CSS nuevas o ajustadas se anadieron para la placa del icono
- como queda tratado el fallback
? - validacion sintactica y visual realizada
- confirmacion explicita de que no se tocaron backend, assets de armas, SVGs, imagenes fisicas, Elo/MMR ni Comunidad Hispana #03
Result:
- Updated
frontend/assets/js/partida-actual.jssorenderKillFeedWeaponIcon()now wraps both the<img>and the?fallback insidecurrent-match-killfeed__weapon-icon-frame. - Updated
frontend/assets/css/historico.csswith a stable light cream weapon plate and adjusted icon/fallback sizing so black transparent SVGs remain readable without changing the weapon mapping. - Kept the weapon label visible below the icon plate and preserved the current kill feed structure and responsive behavior.
Validation performed:
- PASS:
node --check frontend/assets/js/partida-actual.js - PASS:
node --check frontend/assets/js/current-match-weapon-icons.js - PASS: visual local inspection using temporary headless-browser screenshots for desktop and mobile widths confirmed:
- black weapon icon visible over a light plate
- fallback
?rendered inside the same plate - weapon text still visible
- no exaggerated row growth
- responsive layout remained usable
- PASS: reviewed
git status --short --untracked-files=all - PASS: reviewed
git diff --name-only
Scope confirmation:
- No backend file or endpoint was touched.
- No weapon asset, SVG or physical image was modified.
- No weapon mapping or icon path was changed.
ai/system-metrics.mdwas not touched by this task.- Elo/MMR was not reactivated.
- Comunidad Hispana #03 was not reintroduced.
- No push was made.
Change Budget
- Prefer fewer than 5 modified files.
- Prefer changes under 200 lines when feasible.
- Split the work into follow-up tasks if limits are exceeded.