2.6 KiB
2.6 KiB
id, title, status, type, team, supporting_teams, roadmap_item, priority
| id | title | status | type | team | supporting_teams | roadmap_item | priority | ||
|---|---|---|---|---|---|---|---|---|---|
| TASK-239 | Analyze kills per minute column for historical match detail | done | research | Analista |
|
foundation | medium |
TASK-239 - Analyze kills per minute column for historical match detail
Goal
Determine whether a Kills por minuto column can be added honestly to the historical match detail page without reintroducing false KPM.
Files Read First
docs/REAL_KPM_PLAYER_ACTIVE_SECONDS_DESIGN.mdfrontend/assets/js/historico-partida.jsbackend/app/payloads.pybackend/app/rcon_historical_read_model.pybackend/app/rcon_historical_player_stats.py
Findings
historico-partida.jscurrently shows only:- player name
- team
- kills
- deaths
- teamkills
- KD
- The historical match detail payload comes from
build_historical_match_detail_payload()andget_rcon_historical_match_detail(). - The current match detail data includes:
- match duration
- match start/end
- player kills/deaths/teamkills
top_weapons,most_killed,death_by
- The current detail payload does not expose:
player_active_secondsplay_time- per-player presence intervals
- any trustworthy per-player played-minutes field
- The existing design document already states that real KPM is blocked until
player_active_secondsexists as a real materialized field.
Conclusion
Do not implement Kills por minuto now.
The repository still lacks a trustworthy player-level time-played field for historical match detail. Using match duration would only produce kills por minuto de partida, not real player KPM, and that was explicitly ruled out.
Honest Alternatives
Possible future options:
- Real KPM:
- only after
player_active_secondsis materialized per player and per match
- only after
- Explicitly different metric:
Kills/min partida- only if product explicitly wants that weaker metric and labels it as match-duration-based
Implementation Recommendation
Current recommendation: do not add the column yet.
Required before implementation:
- Backend field such as
player_active_seconds - Payload exposure for that field in historical match detail
- Clear UI distinction between:
- real KPM
- kills per match
- any match-duration-derived metric
Validation
- Analysis only
- No frontend implementation changed for this task
- No backend code changed
- No API contract changed
Outcome
The task confirms that real Kills por minuto cannot be implemented safely today and should remain out of the UI until the data model supports it.